Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7810: Private Mode Biometric Authentication #7811

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 1, 2023

This pull request is adding functionality of Biometric - Pin Code local authentication to Tab Mode Changer. It is controlled by toggle in Settings that indicates Private Browsing should be woking under local authentication and on by default also can be switched off by will of users.

The placement of the toggle changed with #7868 so please check out using information there.

Summary of Changes

This pull request fixes #7810

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Step 1

  • Navigate Settings and check there is new entry and toggle for "Private Browsing Lock"
  • Check the toggle is enabled by default

Step 2

  • Navigate back to tab tray and press private button enable private mode
  • Check biometric authentication is presented
  • Test various scenarios like successful id - unsuccessful id and cancel / unlock again permutations

Step 3

  • Validate going to normaa mode while private mode is active doesnt ask for biometrics

Screenshots:

synctest1

RPReplay_Final1690994643.mov

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 1, 2023
@soner-yuksel soner-yuksel self-assigned this Aug 1, 2023
@soner-yuksel soner-yuksel force-pushed the enhancement/authentication-private-tab branch from 5e85e17 to a685ad9 Compare August 2, 2023 14:59
@soner-yuksel soner-yuksel marked this pull request as ready for review August 2, 2023 17:19
@soner-yuksel soner-yuksel requested a review from a team as a code owner August 2, 2023 17:19
@soner-yuksel soner-yuksel changed the title [WIP] Fix #7810: Private Mode Biometric Authentication Fix #7810: Private Mode Biometric Authentication Aug 2, 2023
@soner-yuksel soner-yuksel force-pushed the enhancement/authentication-private-tab branch from a26d0b0 to 347e84d Compare August 3, 2023 17:41
@soner-yuksel
Copy link
Contributor Author

soner-yuksel commented Aug 3, 2023

258192776-3619b3f2-603c-4ffd-9756-72e430115e80

The title is added for Tab Tray Authentication

@soner-yuksel soner-yuksel merged commit ff67224 into development Aug 9, 2023
@soner-yuksel soner-yuksel deleted the enhancement/authentication-private-tab branch August 9, 2023 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private Mode Biometric Authentication
3 participants